Went about 5 years ago, was fantastic, absolutely enthralling city. All the obvious places are well worth a visit, but the more exploring you do the more gems you find.
We stayed in the Milford Plaza just off Times Square, not an amazing place but nice enough and had on the bottom of it a friendly + lively Irish pub that had lots of locals. If it's your first visit there well worth getting the New York Pass which gets you into all the major places and dodge a few queues, only cost about Ł40 but it's probably gone up since then.